Skip to content

Add support for markdownlint-cli2#879

Merged
det merged 7 commits intomainfrom
det/md2
Sep 27, 2024
Merged

Add support for markdownlint-cli2#879
det merged 7 commits intomainfrom
det/md2

Conversation

@det
Copy link
Copy Markdown
Contributor

@det det commented Sep 26, 2024

This pull request introduces a new linter, markdownlint-cli2, and updates the documentation and configuration files accordingly. The most important changes include adding the new linter to the README.md, creating configuration and test files for markdownlint-cli2, and updating existing linter configurations.

Introduction of markdownlint-cli2:

  • Configuration and Test Files:
    • Created a basic test for markdownlint-cli2 in linters/markdownlint-cli2/markdownlint.test.ts.
    • Defined the markdownlint-cli2 tool and its configurations in linters/markdownlint-cli2/plugin.yaml.
    • Added a JSON configuration file for markdownlint-cli2 in linters/markdownlint-cli2/test_data/.markdownlint-cli2.jsonc.
    • Provided test data and expected output for markdownlint-cli2 in linters/markdownlint-cli2/test_data/basic.in.md and linters/markdownlint-cli2/test_data/markdownlint_cli2_v0.14.0_basic.check.shot. [1] [2]

Documentation Updates:

  • README.md:
    • Updated the Markdown linters list to include markdownlint-cli2 in README.md.

Removal of Old Configurations:

  • Old Linter Configurations:
    • Removed outdated markdownlint-cli2 configurations from linters/markdownlint/plugin.yaml.

@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented Sep 26, 2024

⏱️ 30m total CI duration on this PR
Job Cumulative Duration Recent Runs
Linter Tests ubuntu-latest 7m 🟩🟩🟩
Windows Linter Tests 7m 🟩🟩🟩
Trunk Check runner [linux] 5m 🟩🟩🟩
Linter Tests macOS 5m 🟩🟩🟩
CodeQL-Build 4m 🟩🟩🟩
Repo Tests / Plugin Tests 2m 🟩🟩🟩
Detect changed files 22s 🟩🟩🟩
Aggregate Test Results 5s 🟩🟩🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@det det requested a review from TylerJang27 September 26, 2024 19:32
@det det marked this pull request as ready for review September 26, 2024 19:32
@trunk-staging-io
Copy link
Copy Markdown

trunk-staging-io Bot commented Sep 26, 2024

✅ 8 passed ⋅ (learn more)

settingsdocs ⋅ learn more about trunk.io

Copy link
Copy Markdown
Collaborator

@TylerJang27 TylerJang27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One callout

Comment thread README.md
| Kotlin | [detekt], [ktlint] |
| Kubernetes | [kube-linter] |
| Lua | [stylua] |
| Markdown | [deno], [markdownlint], [markdownlint-cli2], [markdown-link-check], [markdown-table-prettify], [prettier], [remark-lint] |
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a link for this below the table

@det det merged commit 512ca70 into main Sep 27, 2024
@det det deleted the det/md2 branch September 27, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants